-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slang: verible: Use gcc-9 #103
Conversation
GitHub Actions virtual environments doesn't have gcc-8 preinstalled anymore: actions/runner-images#2950
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, merge on green
Can we use gcc-10 instead? It should be available: |
You should really be using the Compiler provided in the conda environment. Using the system provided compiler is generally bad idea. |
@tgorochowik This would also require updating the image we build on. Currently used Ubuntu 16.04 for all Linux builds doesn't have gcc-10: https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu1604-README.md @mithro AFAIR these two were impossible to build with a compiler from Conda and at least |
@ajelinski - Can we make sure that is a GitHub issue which is tracking that this problem exists and needs to be fixed in the future? |
@mithro This seems to be a conscious change in the OS image. I can see they are constantly making software changes in the images: https://github.com/actions/virtual-environments/commits/main/images/linux/Ubuntu1604-README.md |
My proposal would be to use one single docker image for having an stable build environment, regardless of the host. The purpose of such image is not for users to consume it, but just to use it in CI as a homogeneization layer on top of whichever VM (virtual environment) the CI provider offers. I think that the dockerfile that builds and the CI that updates the image would fit in hdl/conda-ci. We might then consider providing a ready-to-use However, I agree with Tim that, in the mid term, it'd be better to have it done regardless of the compiler on the system. |
I meant a GitHub issue about the fact the conda package is using the system compiler package. |
@ajelinski I have this pending in my notifications/ToDo: hdl/conda-ci#13 (comment). I just exposed the idea here for others to be aware. |
GitHub Actions virtual environments doesn't have gcc-8 preinstalled
anymore: actions/runner-images#2950